-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to QWebEngine #27
base: master
Are you sure you want to change the base?
Conversation
You can edit .ui files in Btw. I have tried it with QWebEngine and the result is really awful (too much resource intensive - both RAM and CPU). So I am not considering switch to QWebEngine for now, but QHangups can support both (with QtWebKit used by default if available). Things that has to be done before merging:
It can be done, but I don't have resources (time) to do it myself in near future. But thanks for your preliminary work, it could be useful in future. |
or figure out a way to catch the ImportError and then fall back to QWebEngine? |
That's not a problem, this should be default (if QtWebKit is unavailable, fall back to QWebEngine). But user who has QtWebKit installed should still have option to start QHangups with QWebEngine (at least for testing purposes). |
Btw. scrolling can be implemented with |
It seems that whole |
Works on my machine, but needs more testing. Scrolling and resizing detection removed, not available with QWebEngine.